Skip to content

Defer mobile navbar auth loading #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tannerlinsley wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −17
Open

Defer mobile navbar auth loading #1110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 24 additions & 17 deletions src/components/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,6 +693,7 @@ export function Navbar({ children }: { children: React.ReactNode }) {
<MobileNavigation
key={mobileMenuOpen ? 'open' : 'closed'}
activeKey={mobileMenuKey}
loadAuthControls={mobileMenuOpen}
onBack={() => setMobileMenuKey(null)}
onNavigate={() => setMobileMenuOpen(false)}
onOpenLibraries={() => {
Expand Down Expand Up @@ -836,12 +837,14 @@ function DesktopNavDropdown({

function MobileNavigation({
activeKey,
loadAuthControls,
onBack,
onNavigate,
onOpenLibraries,
onSelect,
}: {
activeKey: NavMenuKey | null
loadAuthControls: boolean
onBack: () => void
onNavigate: () => void
onOpenLibraries: () => void
Expand All @@ -859,6 +862,18 @@ function MobileNavigation({
}
}

const signIn = (
<Link
to="/login"
tabIndex={activeGroup ? -1 : 0}
onClick={onNavigate}
className="flex w-full items-center gap-3.5 rounded-xl px-3 py-4 text-left font-ds-display text-ds-heading-3 text-[#a3a3a3] transition-colors hover:bg-[#171717] hover:text-white focus-visible:bg-[#171717] focus-visible:text-white focus-visible:outline-none"
>
<SignInIcon className="size-8 shrink-0" />
Sign In
</Link>
)

return (
<nav aria-label="Mobile navigation" className="overflow-hidden">
<div
Expand Down Expand Up @@ -912,24 +927,16 @@ function MobileNavigation({
<Sparkles className="size-8 shrink-0" />
Ask AI
</button>
<React.Suspense
fallback={
<Link
to="/login"
{loadAuthControls ? (
<React.Suspense fallback={signIn}>
<LazyMobileNavbarAuthControls
tabIndex={activeGroup ? -1 : 0}
onClick={onNavigate}
className="flex w-full items-center gap-3.5 rounded-xl px-3 py-4 text-left font-ds-display text-ds-heading-3 text-[#a3a3a3] transition-colors hover:bg-[#171717] hover:text-white focus-visible:bg-[#171717] focus-visible:text-white focus-visible:outline-none"
>
<SignInIcon className="size-8 shrink-0" />
Sign In
</Link>
}
>
<LazyMobileNavbarAuthControls
tabIndex={activeGroup ? -1 : 0}
onNavigate={onNavigate}
/>
</React.Suspense>
onNavigate={onNavigate}
/>
</React.Suspense>
) : (
signIn
)}
</div>
</div>

Expand Down
Loading