fix(virtual-core): scroll to index should only retry if still targeting the same index#1073
Closed
jb-chief wants to merge 2 commits into
Closed
fix(virtual-core): scroll to index should only retry if still targeting the same index#1073jb-chief wants to merge 2 commits into
jb-chief wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 0a64098 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
piecyk
requested changes
Jan 2, 2026
| scrollOffset: number | null = null | ||
| scrollDirection: ScrollDirection | null = null | ||
| private scrollAdjustments = 0 | ||
| private scrollToIndexTargetIndex: number | null = null |
Collaborator
There was a problem hiding this comment.
Suggested change
| private scrollToIndexTargetIndex: number | null = null | |
| private currentScrollToIndex: number | null = null |
| const scheduleRetry = (align: ScrollAlignment) => { | ||
| if (!this.targetWindow) return | ||
|
|
||
| if (this.scrollToIndexTargetIndex !== index) |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (this.scrollToIndexTargetIndex !== index) | |
| if (this.scrollToIndexTargetIndex !== index) return |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
When calling
scrollToIndexin a tight loop, it no longer retries scrolls for outdated indices.✅ Checklist