fix(virtual-core): prevent measurement jitter when scale is applied#986
Merged
Conversation
🦋 Changeset detectedLatest commit: 4cb29f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 4cb29f8.
☁️ Nx Cloud last updated this comment at |
Collaborator
|
@usings Could you also update observeElementRect to use offsetWidth / offsetHeight as a fallback instead of getBoundingClientRect()? |
Contributor
Author
Sure. I’ll make that change shortly. |
piecyk
requested changes
May 5, 2025
…ional dimensions
piecyk
approved these changes
May 5, 2025
Collaborator
|
Thanks @usings |
Merged
2 tasks
shniubobo
added a commit
to shniubobo/pgpvis
that referenced
this pull request
May 12, 2025
Ref: TanStack/virtual#641 (comment) Ref: TanStack/virtual#986 Changelog: detail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using the
measureElementfunction in combination with scaled elements (via CSStransform: scale(...)), thegetBoundingClientRect()method returns fractional values that may cause layout jitter or re-renders due to rounding inconsistencies.Solution
Fallback measurement now uses
offsetWidth/offsetHeightinstead ofgetBoundingClientRect()whenResizeObserverEntry.borderBoxSizeis not available. This avoids jitter caused by scaled bounding boxes.Why
offset*?offsetWidth/offsetHeightgive integer values.transform: scale(...), unlikegetBoundingClientRect().Impact
Improves measurement stability in virtualized lists using CSS transforms. No breaking changes.