fix: v2 - proper hydration of loaded spec#2437
Merged
maxy-shpfy merged 1 commit intoJun 19, 2026
Merged
Conversation
🎩 PreviewA preview build has been created at: |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
7ab01b2 to
c246e88
Compare
8 tasks
camielvs
reviewed
Jun 19, 2026
camielvs
reviewed
Jun 19, 2026
camielvs
approved these changes
Jun 19, 2026
Collaborator
Author
Merge activity
|
c246e88 to
c06f0c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Closes https://github.com/Shopify/oasis-frontend/issues/659
When a spec is loaded in the Editor, task component references are now hydrated immediately so that the live component spec object model always carries a resolved
componentRef.spec. This is handled by the newhydrateLoadedSpecRefsutility, which walks every task in the spec tree, recursing into subgraph specs rather than attempting to hydrate the subgraph reference itself. Tasks whose references fail to hydrate are left untouched and will surface aCOMPONENT_HYDRATION_FAILEDvalidation issue.The deserialization logic in
useLoadSpechas also been extracted into a standalonedeserializeSpecDatafunction to improve readability and separation of concerns.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
COMPONENT_HYDRATION_FAILEDvalidation issue is surfaced.hydrateSpecRefs.test.tsto confirm all three scenarios pass.Additional Comments
Hydration failures are handled gracefully — the spec continues to load and the affected task is flagged via validation rather than causing a hard error.
Might slow down time-to-operational-editor for massive pipelines