Skip to content

#7 Retain original bitmap size in CropStateManager #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThomasKiljanczykDev wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

#7 Retain original bitmap size in CropStateManager #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
230d917
#7 Maintain a reference to the original bitmap in `CropState` to ensu…
ThomasKiljanczykDev Dec 29, 2025
ad10444
#7 improve the new crop logic to also work with image flipping and ro…
ThomasKiljanczykDev Dec 29, 2025
8a6525e
#7 remove unneeded scaledBitmap property from the CropState
ThomasKiljanczykDev Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions cropkit/src/main/java/com/tanishranjan/cropkit/internal/CropStateManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ internal class CropStateManager(
}

fun crop(): Bitmap {

val state = state.value
val bitmap = state.bitmap
val imageRect = state.imageRect
Expand Down Expand Up @@ -309,7 +308,7 @@ internal class CropStateManager(
contentScale = contentScale
)

val newBitmap = bitmap.scale(scaledSize.width.toInt(), scaledSize.height.toInt())
val scaledBitmap = bitmap.scale(scaledSize.width.toInt(), scaledSize.height.toInt())

val offsetX = (canvasSize.width - scaledSize.width) / 2f
val offsetY = (canvasSize.height - scaledSize.height) / 2f
Expand Down Expand Up @@ -350,12 +349,12 @@ internal class CropStateManager(
_state.update {
it.copy(
canvasSize = canvasSize,
bitmap = newBitmap,
bitmap = bitmap,
imageRect = Rect(
Offset(offsetX, offsetY),
Size(scaledSize.width, scaledSize.height)
),
imageBitmap = newBitmap.asImageBitmap(),
imageBitmap = scaledBitmap.asImageBitmap(),
cropRect = cropRect,
handles = GestureUtils.getNewHandleMeasures(cropRect, handleRadiusPx),
gridlinesActive = gridLinesVisibility == GridLinesVisibility.ALWAYS,
Expand Down