Skip to content

Feature/login modal#181

Open
Kirti-Pant wants to merge 5 commits into
TanmayKalra09:mainfrom
Kirti-Pant:feature/login-modal
Open

Feature/login modal#181
Kirti-Pant wants to merge 5 commits into
TanmayKalra09:mainfrom
Kirti-Pant:feature/login-modal

Conversation

@Kirti-Pant
Copy link
Copy Markdown

🚀 Pull Request

📋 Description

This PR adds a modern, accessible Login modal component to the project and integrates it into the main website.
It includes form validation, a show/hide password toggle, Gravatar avatar integration, post-login user greeting, animated SVG branding, and full accessibility support.
The modal redirects the user to the homepage upon successful login, enhancing the authentication UX across the site.

Key highlights:

Implements Login.tsx as a reusable modal with clean React hooks structure.

Includes Login.css for styling, animations, and responsive design.

Adds Layout.css for site-wide layout consistency (if used).

Integrates Gravatar avatars, toast notifications, and visual feedback.

Ensures accessible form fields, labels, ARIA roles, and screen-reader friendly content.

Fixes #107

🔍 Type of Change

Bug fix 🐞

✅ New feature ✨

✅ Documentation update 📝

Refactoring or code improvement ♻️

Other (please describe):

🙋 Your Details

🧪 How Has This Been Tested?

Describe how you tested your changes.

  1. Manually tested end-to-end by opening the Login modal, entering various email/passwords, checking password validation and show/hide toggle, submitting the form, and verifying:

  2. The greeting and Gravatar avatar display on successful login.

  3. Toast notifications correctly appear for success and errors.

  4. The modal automatically closes and redirects to the homepage.

  5. Checked accessibility with keyboard navigation and screen reader (labels, ARIA, focus management).

📸 Screenshots (if applicable)

Before:
No Login Page
s4

After:
Login Component Added:
s1

s2 s3

s5

s6

✅ Checklist

  • [ ✅] I have read the contributing guidelines.
  • [✅ ] I have followed the code style and linting rules.
  • [ ✅] I have added tests or explained why not.
  • [✅ ] I have updated documentation (if needed).
  • [ ✅] My changes do not introduce any known security issues or vulnerabilities.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 31, 2025

@Kirti-Pant is attempting to deploy a commit to the Tanmay Kalra's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smart-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 5:06pm

@Kirti-Pant
Copy link
Copy Markdown
Author

@TanmayKalra09 is it not merged yet??

@Kirti-Pant
Copy link
Copy Markdown
Author

@TanmayKalra09 kindly merge my PR so that I can get credits of my task done.

@TanmayKalra09
Copy link
Copy Markdown
Owner

Hey @Kirti-Pant, thank you for your efforts, we really appreciate the work you’ve done.
However, we require some changes, which will be communicated to you by @Tanziha-Sheikh and @Unnati-coder25.

@Kirti-Pant
Copy link
Copy Markdown
Author

@TanmayKalra09 will I get my credits??

@TanmayKalra09
Copy link
Copy Markdown
Owner

@TanmayKalra09 will I get my credits??

Yes of course you will get

@Kirti-Pant
Copy link
Copy Markdown
Author

@TanmayKalra09 let me know if Login button is working or not.

@Kirti-Pant
Copy link
Copy Markdown
Author

@Tanziha-Sheikh and @Unnati-coder25 kindly merge my PR.

@Kirti-Pant
Copy link
Copy Markdown
Author

@TanmayKalra09 kindly merge my PR so that I can get my credits.

@Kirti-Pant
Copy link
Copy Markdown
Author

@TanmayKalra09 kindly reply to my messages

@TanmayKalra09
Copy link
Copy Markdown
Owner

@Kirti-Pant Please resolve the conflicts

@TanmayKalra09
Copy link
Copy Markdown
Owner

@TanmayKalra09 kindly merge my PR so that I can get my credits.

Thank you for your contribution. We can only proceed with merging the PR if it is working perfectly and meets all required criteria. If there are any issues or incomplete features, unfortunately, we won’t be able to merge it until those are fully addressed. Please ensure everything is functioning as expected so we can move forward.

@TanmayKalra09
Copy link
Copy Markdown
Owner

@Kirti-Pant Are you working on resolving the conflicts?

@Kirti-Pant
Copy link
Copy Markdown
Author

@TanmayKalra09 yes I'm working on it.

@Kirti-Pant
Copy link
Copy Markdown
Author

@TanmayKalra09 kindly authorize my resolved files.

@Kirti-Pant
Copy link
Copy Markdown
Author

@TanmayKalra09 I resolved the conflicts but still Vercel wants authorization to deploy kindly help me out with this if something has to be done from your end make sure to do it so that my PR can get merged.

@TanmayKalra09
Copy link
Copy Markdown
Owner

Conflicts are not resolved yet. Please resolve the following files: package-lock.json, package.json, and src/App.jsx.

@Kirti-Pant
Copy link
Copy Markdown
Author

@TanmayKalra09 I've resolved the files and did all commits I don't why still showing conflicts.

@TanmayKalra09
Copy link
Copy Markdown
Owner

There are conflicts, which is why this is showing. Please resolve the merge conflicts first.

@Kirti-Pant
Copy link
Copy Markdown
Author

@TanmayKalra09 I'll try it again and let you know as my code is working properly and there are no errors in files opened in VS Code.

@Kirti-Pant
Copy link
Copy Markdown
Author

@TanmayKalra09 I created a new PR kindly look into it as it is showing no conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Adding a Login Page

2 participants