Skip to content

fix: validate user existence and password before login#225

Open
Shrrutii29 wants to merge 2 commits into
TanmayKalra09:mainfrom
Shrrutii29:fix/login-validation
Open

fix: validate user existence and password before login#225
Shrrutii29 wants to merge 2 commits into
TanmayKalra09:mainfrom
Shrrutii29:fix/login-validation

Conversation

@Shrrutii29
Copy link
Copy Markdown

@Shrrutii29 Shrrutii29 commented Aug 11, 2025

🚀 Pull Request

📋 Description

This PR fixes the issue where users could log in without having a registered account and with any password.
Now, the login process validates if the user exists and checks the password correctness before granting access.

Fixes #218

I am submitting this as part of GSSoC’25.

🔍 Type of Change

  • Bug fix 🐞
  • New feature ✨
  • Documentation update 📝
  • Refactoring or code improvement ♻️
  • Other (please describe):

🙋 Your Details

🧪 How Has This Been Tested?

Describe how you tested your changes.

  • Tried logging in with unregistered accounts — login fails with proper error messages.
  • Tried logging in with incorrect passwords — login fails correctly.
  • Logged in with valid credentials — login succeeds.

✅ Checklist

  • I have read the contributing guidelines.
  • I have followed the code style and linting rules.
  • I have added tests or explained why not.
  • I have updated documentation (if needed).
  • My changes do not introduce any known security issues or vulnerabilities.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 11, 2025

@Shrrutii29 is attempting to deploy a commit to the Tanmay Kalra's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smart-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2025 1:28pm

@TanmayKalra09
Copy link
Copy Markdown
Owner

Screenshot 2025-08-11 at 6 59 22 PM It is showing network error but instead it should show that no account has been found or any other related line

@Shrrutii29
Copy link
Copy Markdown
Author

Hi! I’ve fixed the issue where a network error was shown This was caused by a missing import of dotenv. Please review the update.

@Shrrutii29
Copy link
Copy Markdown
Author

Hi, just following up on this PR. Once this is merged, I can continue working on related issues. Please let me know if any changes are needed from my side.

@Shrrutii29
Copy link
Copy Markdown
Author

Shrrutii29 commented Aug 17, 2025

@TanmayKalra09 Please checkout this PR and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Login Succeeds with Any Password and Unregistered Users

2 participants