Skip to content

🧹 Extract string literals 'Lavoro' and 'Riposo' into constants#38

Open
TargetMisser wants to merge 1 commit intomainfrom
refactor/extract-shift-constants-4361916221772028880
Open

🧹 Extract string literals 'Lavoro' and 'Riposo' into constants#38
TargetMisser wants to merge 1 commit intomainfrom
refactor/extract-shift-constants-4361916221772028880

Conversation

@TargetMisser
Copy link
Copy Markdown
Owner

🎯 What
Extracted the hardcoded string literals 'Lavoro' and 'Riposo' into reusable constants (SHIFT_TITLE_WORK and SHIFT_TITLE_REST) in a new file src/constants/shifts.ts. Updated the entire codebase to utilize these constants instead of the raw strings.

💡 Why
This improves maintainability by centralizing the definitions for these important, frequently used domain concepts. It reduces duplication, prevents typos, and makes any future changes or localization efforts regarding these shift titles significantly easier and safer.

Verification

  1. Verified that the constants were correctly imported and used throughout src/screens, src/utils, and src/widgets.
  2. Ran npm run typecheck which confirmed there are no TypeScript compilation errors.
  3. Ran npx jest --passWithNoTests to confirm no tests were broken.
  4. Tested locally to ensure string manipulations match the original format.

Result
A cleaner, more maintainable codebase free of magic string literals for core shift types, resulting in enhanced safety and readbility.


PR created automatically by Jules for task 4361916221772028880 started by @TargetMisser

Extracted 'Lavoro' and 'Riposo' string literals into reusable constants `SHIFT_TITLE_WORK` and `SHIFT_TITLE_REST` in `src/constants/shifts.ts` to improve code maintainability and reduce duplication.
Updated all occurrences in utility functions, components, and screens.

Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flight-work-app Ready Ready Preview, Comment, Open in v0 Apr 6, 2026 1:57pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant