Open
Conversation
- Fix DrawerMenu: icon color hardcoded #2563EB -> colors.primary (theme-aware) - Fix DrawerMenu: version label 'v1.0' -> 'v1.1.0' (matches package.json) - Remove CalendarScreen: module-level const PRIMARY = '#2563EB', replaced with colors.primary - Fix NotepadScreen: saveBtnDim hardcoded backgroundColor -> opacity: 0.55 (works in all themes) - Replace all makeStyles(c: any) -> makeStyles(c: ThemeColors) across 8 files (14 occurrences): DrawerMenu, ShiftTimeline, NotepadScreen, FlightScreen, HomeScreen, CalendarScreen, PhonebookScreen (x3), PasswordScreen (x3), ManualsScreen (x3) - Add 'type ThemeColors' to imports in all affected files - Wrap all console.error/warn in if (__DEV__) guard (20+ occurrences): CalendarScreen (x6), FlightScreen (x5), HomeScreen (x4), PasswordScreen (x3), autoNotifications.ts (x3), useDynamicTheme.ts (x1) - App.tsx: guard auto-notification count log with __DEV__ Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- DrawerMenu: import version from package.json instead of hardcoded string - eliminates version drift between package.json and UI - requires resolveJsonModule (included in expo/tsconfig.base) - NotepadScreen: add comment explaining intentional opacity cascade on saveBtnDim - opacity: 0.55 dims entire button (icon + label + bg) for 'already saved' state - intentional UX: full-button fade signals inactive state - Add src/utils/devLog.ts utility (devLog/devWarn/devError) - centralises __DEV__ guards for future use - Metro eliminates dead branches in production bundles Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosa cambia
Coerenza del tema
#2563EB→colors.primary(theme-aware, si adatta a chiaro/scuro)v1.0→v1.1.0(allineata alpackage.json)const PRIMARY = '#2563EB'a livello modulo →colors.primarysaveBtnDim: { backgroundColor: '#93C5FD' }hardcodato →opacity: 0.55(funziona con tutti i temi)Type safety — eliminati tutti gli
anynei makeStyles14 occorrenze di
makeStyles(c: any)→makeStyles(c: ThemeColors)in 8 file + aggiuntotype ThemeColorsagli import:DrawerMenu.tsx,ShiftTimeline.tsx,NotepadScreen.tsx,FlightScreen.tsx,HomeScreen.tsx,CalendarScreen.tsxPhonebookScreen.tsx(×3: makeModalStyles, makeRowStyles, makeStyles)PasswordScreen.tsx(×3: makePinStyles, makeRowStyles, makeStyles)ManualsScreen.tsx(×3: makeItemStyles, makeSectionStyles, makeStyles)Console log solo in dev — no leak in produzione
Tutti i
console.error/console.warn(20+ occorrenze) avvolti inif (__DEV__):CalendarScreen.tsx(×6),FlightScreen.tsx(×5),HomeScreen.tsx(×4)PasswordScreen.tsx(×3),autoNotifications.ts(×3),useDynamicTheme.ts(×1),App.tsx(×1)12 file modificati | ~51 righe inserite / ~52 rimosse