🎨 Palette: Fix dark mode shadow bleeding on PinnedFlightCard#65
Conversation
Fixes an issue where a colored shadow was bleeding through the semi-transparent card background in dark mode, appearing as an unwanted orange inner border on Android. - Updated `PinnedFlightCard` to use a solid black shadow (`#000000`) in dark mode, aligning with the behavior of other cards and preventing visual bleeding. Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fixes an issue where a colored shadow was bleeding through the semi-transparent card background in dark mode, appearing as an unwanted orange inner border on Android. - Updated `PinnedFlightCard` to use a solid black shadow (`#000000`) in dark mode, aligning with the behavior of other cards and preventing visual bleeding. - Synced `package-lock.json` via `npm install` to resolve CI `npm ci` EUSAGE failure. Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
1 participant
🎯 What: Fixes an issue on the
HomeScreenwhere thePinnedFlightCardhad a noticeable inner border/glow artifact in dark mode on Android devices.💡 Why: The issue was caused by using a colored
shadowColor(colors.primary) combined withelevationon a component with a semi-transparentbackgroundColor(colors.card). In Android, shadows render "behind" the view, and if the view is translucent, a colored shadow bleeds through, creating an inner glow effect. Changing the shadow to solid black (#000000) when in dark mode prevents this artifact.📸 Before/After: The "bordo interno a caso" (random inner border) on the orange "Pinnato" card is removed.
♿ Accessibility: Purely visual polish; no accessibility impact.
PR created automatically by Jules for task 14808689681990295666 started by @TargetMisser