Prepare public replay corpus release#48
Merged
Merged
Conversation
There was a problem hiding this comment.
2 issues found across 32 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/verify.yml">
<violation number="1" location=".github/workflows/verify.yml:14">
P2: Pin GitHub Actions to full commit SHAs instead of version tags to reduce CI supply-chain risk.</violation>
</file>
<file name="apps/web/src/App.tsx">
<violation number="1" location="apps/web/src/App.tsx:1098">
P2: Event-type coverage uses only `corpus_quality.metrics`, so fallback corpus data is ignored and the coverage map can incorrectly show all required event types as missing.</violation>
</file>
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
| @@ -0,0 +1,31 @@ | |||
| name: Verify | |||
There was a problem hiding this comment.
P2: Pin GitHub Actions to full commit SHAs instead of version tags to reduce CI supply-chain risk.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/verify.yml, line 14:
<comment>Pin GitHub Actions to full commit SHAs instead of version tags to reduce CI supply-chain risk.</comment>
<file context>
@@ -0,0 +1,31 @@
+ runs-on: ubuntu-latest
+ steps:
+ - name: Check out repository
+ uses: actions/checkout@v4
+
+ - name: Set up Python
</file context>
| const validationRate = corpusQuality?.metrics.top_ranked_validated_rate | ||
| ?? validationCases?.aggregate?.top_ranked_validated_rate | ||
| ?? null; | ||
| const coveredEventTypes = new Set(corpusQuality?.metrics.event_types ?? []); |
There was a problem hiding this comment.
P2: Event-type coverage uses only corpus_quality.metrics, so fallback corpus data is ignored and the coverage map can incorrectly show all required event types as missing.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/src/App.tsx, line 1098:
<comment>Event-type coverage uses only `corpus_quality.metrics`, so fallback corpus data is ignored and the coverage map can incorrectly show all required event types as missing.</comment>
<file context>
@@ -1061,6 +1078,260 @@ function ModeTabs({ activeMode, onChange }: { activeMode: Mode; onChange: (mode:
+ const validationRate = corpusQuality?.metrics.top_ranked_validated_rate
+ ?? validationCases?.aggregate?.top_ranked_validated_rate
+ ?? null;
+ const coveredEventTypes = new Set(corpusQuality?.metrics.event_types ?? []);
+ const nextAction = corpusQuality?.next_action ?? 'Generate demo assets after adding verified real-curated bundles.';
+
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Notes
Summary by cubic
Prepares the public replay corpus for release with six verified real-curated cases across four event types, a new Corpus mode with per-case quality, and a polished public presentation. Raises corpus gates, adds a deterministic curation CLI, hardens source discovery, and wires verification for a safe public build.
New Features
real-case-workflowCLI for deterministic, offline-friendly curation with tests; expandedsource_discoveryto reject private DNS/credentialed URLs, cap fetch size/redirects, and support gzip/deflate, with new tests.vercel.json.Migration
npm run verify:releaselocally; CI runsnpm run verify.vercel.json(npm ci,npm run web:build, output toapps/web/dist); production publish remains a manual step.Written for commit 8b87fbc. Summary will update on new commits.