feat: add input validation/sanitization and error handling/logging in real-time gateway endpoints#145
Open
slopefields wants to merge 6 commits intodevfrom
Open
feat: add input validation/sanitization and error handling/logging in real-time gateway endpoints#145slopefields wants to merge 6 commits intodevfrom
slopefields wants to merge 6 commits intodevfrom
Conversation
…dpoint_sanitization
…point_sanitization
jrb00013
requested changes
Mar 17, 2026
| const MAX_BODY_KEYS = 50; | ||
| const MAX_STRING_VALUE_LENGTH = 10000; | ||
| const APP_HEADER_PREFIX = 'x-'; | ||
| const ALLOWED_GAMIFICATION_EVENT_TYPES = new Set([ |
Member
There was a problem hiding this comment.
This is useless, we don't need gamification types
| }; | ||
| }; | ||
|
|
||
| export const validateEmitGamificationBody: BodyValidator = (body: Record<string, unknown>): string | null => { |
| res.json({ success: true }); | ||
| }); | ||
| // Emit based on type | ||
| switch (type) { |
Member
There was a problem hiding this comment.
Factor this out, this is unnecessary
Member
Member
|
@Team-Deepiri/support-team someone test this @slopefields reference your other PRs from other repos into here |
Member
|
@slopefields take out all gamification stuff |
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds input (body, header, query) validation/sanitization and error handling/logging across real-time gateway endpoints
Changes
Related
Related PRs (not dependent):
deepiri-external-bridge-service: Team-Deepiri/deepiri-external-bridge-service#35
deepiri-auth-service: Team-Deepiri/deepiri-auth-service#31
deepiri-api-gateway: Team-Deepiri/deepiri-api-gateway#40
Testing
Workflow Checklist
Review Requests
@Team-Deepiri/support-team