Conversation
Closed
7 tasks
pparkjs
force-pushed
the
feature-27/crew-member-ban
branch
from
1fe0678 to
7bab731
Compare
xjvmdutl
reviewed
Aug 31, 2025
| import java.util.UUID; | ||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface CrewBanMemberRepository extends JpaRepository<CrewBanMember, UUID> { |
Collaborator
There was a problem hiding this comment.
@pparkjs 님
읽기 전용으로 사용하는 거면 ReadRepository를 쓰는것이 좋을거 같습니다.
mandykr
approved these changes
Sep 1, 2025
| Crew crew = findCrewById(crewId); | ||
| crew.validateCrewLeader(loginMemberId); | ||
| List<CrewBanMember> crewBanMembers = crewBanMemberRepository.findAllByCrewId(crewId); | ||
| return CrewBanListResponse.from(crewBanMembers); |
Contributor
There was a problem hiding this comment.
from -> of 로 메소드명 통일하는게 좋겠어요
Comment on lines
+166
to
+170
| @Override | ||
| public void banMember(UUID loginMemberId, UUID crewId, UUID bannedMemberId) { | ||
| Crew crew = findCrewById(crewId); | ||
| crew.banMember(loginMemberId, bannedMemberId); | ||
| } |
Contributor
There was a problem hiding this comment.
차단 후에 어떤 데이터를 api 응답으로 보내주는게 맞을지 같이 고민해보는게 좋겠어요
pparkjs
force-pushed
the
feature-27/crew-member-ban
branch
from
7bab731 to
0607619
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 PR 타입 선택
아래 타입 중 해당하는 하나를 선택해 주세요. 반드시 하나만 선택해 주세요.
feat: 새로운 기능 추가fix: 버그 수정docs: 문서 수정style: 코드 포맷팅, 세미콜론 누락, 코드 변경이 없는 경우refactor: 코드 리팩토링test: 테스트 코드 추가 또는 수정chore: 빌드 업무 수정, 패키지 매니저 수정 등 기타 작업📝 변경 사항 요약
변경 사항을 간단히 요약해 주세요.
🛠 관련 이슈
Resolves: #27 ,#9
close: #27
close: #9
추가 설명 (선택 사항)
변경 사항에 대한 추가 설명을 작성해 주세요.