Auto ranging#338
Open
Glowdisk wants to merge 17 commits into
Open
Conversation
Contributor
|
⭐⭐ Can you add some unit tests to prove this works? |
Rongrrz
reviewed
Mar 28, 2026
Contributor
Rongrrz
left a comment
Rongrrz
left a comment
There was a problem hiding this comment.
If you are using interpolating tree map, you shouldn't have to do any rounding
Rongrrz
reviewed
Apr 1, 2026
|
|
||
| for (boolean zeroHood : new boolean[]{false, true}) { | ||
| for (int i = 0; i < 10; i++) { | ||
| double randomWidth = rand.nextDouble() * 4.03; // 4.03 is the width of the alliance zone |
Contributor
There was a problem hiding this comment.
⭐ Can we store this value somewhere or have a function for calculation like what vision does? (And I'd think that they probably already have a function to get the width/height of the alliance zone)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
Finding distance to the hub so we can set a RPM and hood.
Asana task URL:
https://app.asana.com/1/2086102074315/project/1212432746991352/task/1213811082673949
Whats changing?
Changing method of finding distance to use a interpolatingTreeMap.
Questions/notes for reviewers
How this was tested
Video/screenshots (from simulator or live robot)
PR feedback legend