Terune pntake iivot

[maiKuneho]

No description provided.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3a6e6fd9-cb5d-4820-a32a-0ba9b40a690a

📥 Commits

Reviewing files that changed from the base of the PR and between c282253 and 94b1264.

📒 Files selected for processing (4)

• src/main/java/org/team5924/frc2026/Constants.java
• src/main/java/org/team5924/frc2026/RobotContainer.java
• src/main/java/org/team5924/frc2026/subsystems/pivots/intakePivot/IntakePivot.java
• src/main/java/org/team5924/frc2026/subsystems/pivots/intakePivot/IntakePivotIOTalonFX.java

---

Summary by CodeRabbit

• New Features

  • Added manual control mode for intake pivot using controller left X axis.
  • Added bumper controls to move intake to DOWN and STOW positions.
  • Added trigger-based intake spitout functionality.
  • Introduced new intake positioning state for improved control precision.

• Chores

  • Adjusted motor tuning parameters for intake pivot performance optimization.

Walkthrough

The PR refactors position bounds naming in motor subsystem constants from MULTI-based to ROTATIONS-based constants across four subsystems (IntakePivot, GeneralShooterHood, TurretLeft, TurretRight), updates control wiring and I/O implementations in RobotContainer, introduces a new PHYSICAL_STOW enum state, and adjusts PID tuning parameters.

Changes

Cohort / File(s)	Summary
Constants Refactoring src/main/java/org/team5924/frc2026/Constants.java	Replaced MIN/MAX_POSITION_MULTI with MIN/MAX_POSITION_ROTATIONS across IntakePivot, GeneralShooterHood, TurretLeft, and TurretRight. Updated soft-limit configuration references and dependent RADS calculations to use new ROTATIONS constants.
Control Wiring & I/O src/main/java/org/team5924/frc2026/RobotContainer.java	Updated IntakePivot and Intake I/O implementations to use IOTalonFX paths; added control bindings for operatorController bumpers (intakePivot DOWN/STOW) and driveController leftTrigger (SPITOUT flow); introduced IntakePivotState and IntakeState imports.
Intake Pivot State & Tuning src/main/java/org/team5924/frc2026/subsystems/pivots/intakePivot/IntakePivot.java, src/main/java/org/team5924/frc2026/subsystems/pivots/intakePivot/IntakePivotIOTalonFX.java	Added PHYSICAL_STOW enum constant (2.1 rad); updated STOW from 2.45 to 2.05 rad. Adjusted PID tuning (kP: 70.0→40.0, kD: 0.0→0.5, kS: 1.5→0.2) and changed initial position initialization to PHYSICAL_STOW.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• added CanCoder to shooter hood through Constants.java, ShooterHoodIO.… #60: Introduced MIN/MAX_POSITION_MULTI constants in Constants.java that are now replaced with ROTATIONS-based variants in this PR.
• Implement Intake Pivot #65: Added initial IntakePivot subsystem, I/O implementation, and position constants that this PR refactors and enhances.
• drive controls #76: Modified RobotContainer operator control bindings for intake/intakePivot, directly related to the control wiring updates in this PR.

Suggested reviewers

• arcadeArchitect
• thatnerdjack
• marisa07

Poem

🐰 Constants dance in rotation's grace,
From MULTI bounds to ROTATIONS' place,
PHYSICAL_STOW takes its humble stance,
PID tuning finds its perfect dance,
Control flows smooth—the intake's leap! 🎯

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch terune-pntake-iivot

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.