Skip to content

Image size, comments box size#7

Merged
marisa07 merged 11 commits into
mainfrom
comments-fonts-css
Feb 28, 2026
Merged

Image size, comments box size#7
marisa07 merged 11 commits into
mainfrom
comments-fonts-css

Conversation

@marisa07
Copy link
Copy Markdown

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 28, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7e2972 and 63d5b80.

⛔ Files ignored due to path filters (2)
  • 2026/half_field-old.png is excluded by !**/*.png
  • 2026/half_field.png is excluded by !**/*.png
📒 Files selected for processing (3)
  • 2026/rebuilt_config.js
  • resources/css/scoutingPASS.css
  • resources/js/scoutingPASS.js

Summary by CodeRabbit

  • New Features

    • Added multi-line text input support for comments and extended text fields.
    • Improved responsive image sizing in form displays.
  • Bug Fixes

    • Enhanced coordinate tracking for field interactions with improved scaling accuracy.
    • Updated form reset logic for better field handling.
  • Configuration

    • Adjusted pre-match and endgame form options.
    • Expanded comments field capacity for additional information entry.

Walkthrough

The PR updates form configuration parameters, refines canvas and image styling, and modifies input handling logic. It adjusts game field dimensions, endgame response keys, increases comment field capacity, and enhances JavaScript for scaled coordinate calculations and multi-line text inputs.

Changes

Cohort / File(s) Summary
Configuration Updates
2026/rebuilt_config.js
Modified game field dimensions (auto pre-match "7 10" → "1 5", teleop autonomous "7 10" → "2 3"), narrowed allowableResponses, changed endgame climb response key from "a" to "f", increased Comments field maxSize from 55 to 200 with new rows property.
Styling Enhancements
resources/css/scoutingPASS.css
Added responsive sizing to image field with explicit width (225px), max-width (500px), and height (auto) constraints.
Input & Canvas Logic
resources/js/scoutingPASS.js
Set explicit canvas dimensions, conditionally render textarea for multi-line inputs when data.rows is present, extend form reset logic to handle TEXTAREA elements, implement scaled coordinate calculations using getBoundingClientRect for accurate field click positioning.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 Hops of joy through config files I bound,
Canvases now scale with pixel-perfect sound,
Textareas bloom where comments grow long,
Coordinates calculated, nothing goes wrong!
A scouting form now singing its song! 🎯

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch comments-fonts-css

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@marisa07 marisa07 merged commit d8fd6ca into main Feb 28, 2026
3 of 4 checks passed
@marisa07 marisa07 deleted the comments-fonts-css branch February 28, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant