Skip to content

Intake two motor follow#37

Merged
wayx112 merged 40 commits intomainfrom
IntakeTwoMotorFollow
Mar 6, 2026
Merged

Intake two motor follow#37
wayx112 merged 40 commits intomainfrom
IntakeTwoMotorFollow

Conversation

@wayx112
Copy link
Copy Markdown
Contributor

@wayx112 wayx112 commented Feb 20, 2026

No description provided.

@wayx112 wayx112 self-assigned this Feb 20, 2026
Hannahjjj97
Hannahjjj97 reviewed Feb 21, 2026
View reviewed changes
Comment thread src/main/deploy/pathplanner/navgrid.json Outdated
@Hannahjjj97
Copy link
Copy Markdown
Contributor

Hannahjjj97 commented Feb 21, 2026

你如果想被 review 要記得 request review 喔 不然如果還在改要把這個 pr 變成草稿

kennhung
kennhung requested changes Feb 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kennhung kennhung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不應該改到無關的檔案

  • .OutlineViewer/outlineviewer.json
  • src/main/deploy/pathplanner/navgrid.json

另外，感覺可以把 deploy、retract 寫在一起（因為他們邏輯類似，只是方向相反？

還有，可以把 method 根據相關性重新排列一下，然後 left, right 的順序可以改的一致一點，不要一下先 left 一下先 right

Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java Outdated
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java Outdated
kennhung
kennhung requested changes Feb 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kennhung kennhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

請修正前一次提到的問題

@wayx112 wayx112 requested a review from kennhung February 21, 2026 14:03
kennhung
kennhung requested changes Feb 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kennhung kennhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

除了我留的 comment 之外，在 command 命名的部分，我覺得有些要重新調整一下
特別是什麼樣的操作叫做 manual？可能也需要討論一下

Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java Outdated
Comment thread src/main/java/frc/robot/Constants.java Outdated
Comment thread src/main/java/frc/robot/Constants.java Outdated
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java Outdated
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java Outdated
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java Outdated
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java Outdated
@wayx112 wayx112 requested a review from kennhung February 22, 2026 04:37
kennhung
kennhung reviewed Feb 22, 2026
View reviewed changes
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java Outdated
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java Outdated
@wayx112 wayx112 requested a review from Hannahjjj97 March 1, 2026 08:16
kennhung
kennhung reviewed Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kennhung kennhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大部分都沒問題了，剩下那個 Constnat 的名稱要確認一下

Comment thread src/main/java/frc/robot/Constants.java Outdated
Hannahjjj97
Hannahjjj97 requested changes Mar 5, 2026
View reviewed changes
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java
Hannahjjj97
Hannahjjj97 requested changes Mar 5, 2026
View reviewed changes
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java Outdated
@wayx112 wayx112 requested a review from Hannahjjj97 March 5, 2026 04:56
kennhung
kennhung previously approved these changes Mar 5, 2026
View reviewed changes
@wayx112 wayx112 enabled auto-merge March 5, 2026 14:21
Hannahjjj97
Hannahjjj97 reviewed Mar 6, 2026
View reviewed changes
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java Outdated
Hannahjjj97
Hannahjjj97 reviewed Mar 6, 2026
View reviewed changes
Comment thread src/main/java/frc/robot/subsystems/IntakeSubsystem.java Outdated
@BrianHu0925
Copy link
Copy Markdown

BrianHu0925 commented Mar 6, 2026

有沒有辦法把一些 methods 跟 commands 重新排列一下，增加可讀性？

@wayx112 wayx112 requested a review from Hannahjjj97 March 6, 2026 10:05
@wayx112 wayx112 added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit acd7c7d Mar 6, 2026
8 checks passed
@wayx112 wayx112 deleted the IntakeTwoMotorFollow branch March 6, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennhung kennhung kennhung approved these changes

@BrianHu0925 BrianHu0925 BrianHu0925 approved these changes

@Hannahjjj97 Hannahjjj97 Hannahjjj97 approved these changes

+1 more reviewer

@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@wayx112 wayx112

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wayx112 @Hannahjjj97 @BrianHu0925 @kennhung @yu-yue1025