Fix ANTLR grammar: add catch-all hidden lexer rule to prevent tokeniz…#502
Open
rayan6ms wants to merge 1 commit intoTeamDman:1.19.2from
Open
Fix ANTLR grammar: add catch-all hidden lexer rule to prevent tokeniz…#502rayan6ms wants to merge 1 commit intoTeamDman:1.19.2from
rayan6ms wants to merge 1 commit intoTeamDman:1.19.2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using the generated antlr files on my editor (Yes, I'm that guy)
And I noticed some mismatched syntax errors when using "back side" or "front side" even though they were in the code. Upon investigating, I noticed that there was some Java code on the platform/visual-studio-code/super-factory-manager-language/syntaxes/SFML.g4 file, and as the target is typescript, I changed it to the correct grammar syntax.
PS: I did not regenerate the antlr files for this PR, to update the extension, you still have to run the antlr command.