Allow ebcdic 2.x#479
Open
adamzr wants to merge 1 commit into
Open
Conversation
Issue TeamMsgExtractor#478 ebcdic 2.0 is a pure technical release with no functional changes; it only drops support for Python 2 and 3.8. Keeping the lower bound at 1.1.1 means installs on Python 3.8 continue to resolve to ebcdic 1.1.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requirements.txt:ebcdic>=1.1.1,<2→ebcdic>=1.1.1,<3.next-release).tests.pysuite passes locally withebcdic==2.0.1installed.flake8 . --select=E9,F63,F7,F82clean.next-releasebranch (orv0.29if applicable)?Summary
Resolves #478. Per the ebcdic changelog, the 2.0 release is "a pure technical release that does not change the functionality of the package" — it only modernizes the build toolchain and drops support for Python 2 and 3.8.
Because
extract_msgstill supports Python 3.8 (persetup.pyand the CI matrix in.github/workflows/python-package.yml), this PR widens the upper bound instead of requiringebcdic>=2. The lower bound is unchanged, so on Python 3.8 pip will continue to resolve toebcdic 1.1.1; on Python 3.9+ it can now also pick up2.x.This is analogous to #469 / #472 for
beautifulsoup4.Verification
extract_msg/encoding/__init__.pyusesebcdiconly asimport ebcdic as _to register codecs on import. Confirmed all EBCDIC code pages referenced in_CODE_PAGES(e.g.cp1140,cp1141,cp1148ms,cp290,cp420,cp424,cp833,cp838,cp870,cp1097,cp1149,cp273,cp277,cp278,cp280,cp284,cp285,cp297,cp1025) resolve viacodecs.lookup()withebcdic==2.0.1installed.python tests.py: 20 passed, 2 skipped (user-test-files-only).flake8 . --select=E9,F63,F7,F82: 0 issues.