Option to hide fully watched videos from History page #13260#13275
Option to hide fully watched videos from History page #13260#13275SandipLow wants to merge 4 commits intoTeamNewPipe:devfrom
Conversation
|
I am not sure if it is universal feeling but I feel that check is kinda inverted? |
| <LinearLayout | ||
| android:layout_width="match_parent" |
There was a problem hiding this comment.
Is it necessary to add new LinearLayout (especially taking into account nested views performance considerations)? I am not sure but it seems to me that you could just expand existing RelativeLayout (?)
(It is not a "suggestion" because I am not fully sure by myself)
There was a problem hiding this comment.
Well actually the onclick listener for toggle sortMode is defined for the entire RelativeLayout.. hence why I did that..!
There was a problem hiding this comment.
Ok. Not sure why comment didn't appear before 🤔.
Makes sense. But you could do like done in settings_notification_action.xml#notificationActionClickableArea but I am not sure it is the way to go so wait until real reviewer will come...
| <string name="unknown_format">Unknown format</string> | ||
| <string name="unknown_quality">Unknown quality</string> | ||
| <string name="unknown_audio_track">Unknown</string> | ||
| <string name="feed_show_watched">Fully watched</string> |
There was a problem hiding this comment.
There exists feed_show_watched maybe it should be renamed to show_watched or fully_watched and just reused. What other will say?
| if (!includeFullyWatched) { | ||
| return results.stream() | ||
| .filter(e -> e.getStreamEntity().getDuration() != e.getProgressMillis() / 1000) | ||
| .toList(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Just a note: there is StreamStateEntity.isFinished but it is another entity. Method uses StreamStatisticsEntry
There was a problem hiding this comment.
Oh okay.. I didn't know that.. Will refactor the code..
Imo there should be a "Hide watched" button |
- Implemented isFinished in StreamStatisticsEntry.kt
ShareASmile
added
feature request
3 participants
What is it?
refactorbranchDescription of the changes in your PR
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence