feat: allow filtering out paid feed streams#13371
Draft
diogotcorreia wants to merge 1 commit intoTeamNewPipe:devfrom
Draft
feat: allow filtering out paid feed streams#13371diogotcorreia wants to merge 1 commit intoTeamNewPipe:devfrom
diogotcorreia wants to merge 1 commit intoTeamNewPipe:devfrom
Conversation
This commit adds a new "Members only" filter to the feed page. To achieve this, a database migration is required to save the content availability of streams. Closes TeamNewPipe#12883 Relates to TeamNewPipe#12011 Relates to TeamNewPipe#12040
5 tasks
Author
|
I'm guessing this is enough of a feature (especially given the database migrations) to be targeted at the refactor branch instead. What is the "backport" policy for newpipe? Would it make sense to get this feature/fix on both dev/refactor? Also, feel free to suggest better names. I think "members only" might not be the best. Keeping this as draft because it is missing database migration tests as well |
TobiGr
added
feature request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
This PR adds a new "Members only" filter to the feed page. To achieve this, a database migration is required to save the content availability of streams.
Before/After Screenshots/Screen Record
// TODO
Fixes the following issue(s)
Closes #12883
Relates to #12011
Relates to #12040
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence