fix: 초대 배너 펼침 영역이 상품 이미지에 가려지는 문제 - #500
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Discord 스레드 연동용 메타데이터입니다. discord-pr-bot 워크플로가 자동 생성하며, 수정·삭제하면 PR 과 Discord 알림 연동이 끊깁니다. |
|
Warning Review limit reached
Next review available in: 116 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughParticipantPanel의 펼쳐진 참가자 목록 패널이 Tailwind Changes참가자 패널 표시 순서
Estimated code review effort: 1 (Trivial) | ~3 minutes Mergeability Score: ⚪ Minimal · up to This localized UI layering fix changes the invite banner’s overlay priority so its expanded participant list remains visible above product images; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
작업 요약
작업 세부 내용
토너먼트 준비(담기) 화면에서 상단 초대 배너("N명이 함께 담는 중")를 펼치면, 펼쳐진 참가자 목록이 아래 바구니의 상품 이미지 뒤로 들어가 가려지는 문제를 수정했습니다.
원인
z-10을 하드코딩하고 있었습니다.TournamentCreateClient의.px-5,ParticipantPanel의.relative w-full모두z-index: auto라 스택 컨텍스트를 만들지 않습니다.BaseImage가zIndex: Z_INDEX.BASE_IMAGE(10) 를 걸고,TournamentBasketItem의relative/absolute조상들은 전부z-auto입니다.BASE_IMAGE + 10(20) 이라 항상 배너를 덮었습니다.수정
하드코딩된
z-10을 제거하고 기존 토큰Z_INDEX.POPOVER(40) 를 적용했습니다.토큰 선택 근거 — 새 토큰 추가 없이
POPOVER재사용components/popover/index.tsx가 같은 토큰을 씁니다.BASE_IMAGE(10), 친구 뱃지BASE_IMAGE + 10(20),BOTTOM_TAB_BAR(20),BOTTOM_CTA(30) 보다 위 → 가려지지 않습니다.DIALOG/DRAWER(50) 보다 아래 →InviteFriendsDialog·실패 드로어는 여전히 배너를 덮습니다.BASE_IMAGE + n상대값은 이미지 스택 내부 뱃지/썸네일 겹침용 관용구라 화면 레이어 오버레이에는 맞지 않는다고 판단했습니다.적용 방식은 프로젝트 전역 관용구인
style={{ zIndex: Z_INDEX.X }}를 따랐습니다 (dialog,drawer,popover,bottom-cta,bottom-tab-bar,base-image등 동일). Tailwind 쪽에 z-index 토큰(--z-*)이 없어 임의 클래스(z-[40])는 만들지 않았습니다.스크린샷
연관 이슈
closes #477
Summary by CodeRabbit