feat: INCOMPLETE 파싱 알림 타입·SSE 상태 대응 - #521
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Discord 스레드 연동용 메타데이터입니다. discord-pr-bot 워크플로가 자동 생성하며, 수정·삭제하면 PR 과 Discord 알림 연동이 끊깁니다. |
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- 서버가 파싱이 일부만 끝난 경우 ITEM_PARSING_INCOMPLETE 알림과 status=INCOMPLETE SSE 를 보낸다 (TeamPiKi/core#945). 모르는 타입이라 switch default 로 빠져 딥링크가 동작하지 않았다 - 알림함·푸시·SSE 세 라우팅에 케이스를 더한다. 목적지는 기존 파싱 알림과 같다(위시 또는 토너먼트 담기 화면) - SSE 토스트는 실패와 갱신 대상이 같아 케이스를 합치되 문구만 info 로 가른다 — 실패가 아니라 "채워 주세요" 안내라서다
kanghaeun
changed the title
kanghaeun
force-pushed
the
feature/519-notification-incomplete
branch
from
August 15, 2026 16:25
46a2e53 to
351a437
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
왜
서버가 파싱이 일부만 끝난 경우
ITEM_PARSING_INCOMPLETE알림과status=INCOMPLETESSE 를 새로 보낸다 (TeamPiKi/core#945). 클라는 모르는 타입이라switchdefault 로 빠져 알림을 눌러도 아무 데도 가지 않는다.무엇을
info로 분기. 실패가 아니라 "채워 주세요" 안내라서다NotificationTypeT,PUSH_NOTIFICATION_TYPE,DeepLinkPayloadT,SilentSyncSsePayloadT.status에 값 추가참고
위시 카드와 아이템 상태 대응은 #518 로 분리했다. 두 PR 은 파일이 겹치지 않아 독립적으로 머지할 수 있다.
연관 이슈