README 진행 상태 로그 삭제와 구조 최신화 - #34
Merged
Merged
Conversation
- 완료 트랙의 날짜별 작업 로그(진행 상태 섹션)를 삭제. 기록은 git 이력과 PR 이 소유한다 - 구조 트리에 observability.md·run_container·alloy 블록을 반영하고 SSH 단일 transport 확정을 본문에 반영 (로컬 체크아웃에 커밋되지 않은 채 남아 있던 문서 개선을 흡수) - 전체 시스템 구성은 core README 를 참조하도록 한 줄 추가
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughREADME.md가 배포 공통화 구조를 정리했다. 서비스별 Changes배포 공통화 문서
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 47-52: Update the README directory description for blocks/ so it
no longer claims the directory contains only pure Bash; describe it as
containing shared execution-neutral blocks, including observability
configuration such as the alloy subdirectory and config.alloy.
- Around line 46-52: install.sh의 정본 자산 목록과 복사 대상 경로에 contracts/observability.md,
blocks/run_container.sh, blocks/run_container.test.sh,
blocks/alloy/config.alloy, blocks/alloy/provision-alloy.sh를 추가하세요. 새 Alloy 블록이
실제 설치되도록 provision-alloy.sh의 호출부와 SSM 주입 기준도 함께 갱신하고, README의 SSET 설명과 일치하는지
확인하세요.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
- blocks/ 를 순수 bash 로 서술했지만 alloy/ 의 config.alloy 는 관측 설정이라 불일치 (CodeRabbit 지적 수용) - install.sh 가 배포 갈래(blocks·contracts)까지 설치한다는 오독이 나와, 설치 대상이 개발 규약 갈래뿐임을 주석에 명시. 배포 자산은 각 서비스 deploy 가 원격 fetch 로 소비한다
# Conflicts: # README.md
- main 의 #33(infra 자신에도 스킬 설치)이 진행 상태 불릿을 수정해 삭제와 충돌했다. 로그 삭제는 유지하고, 바뀐 사실만 유지되는 구조 트리 주석에 흡수
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Situation
Task
Action
Result
연관 이슈
Summary by CodeRabbit