This repository was archived by the owner on Dec 23, 2022. It is now read-only.
Use prop-types lib instead of deprecated React.PropTypes#100
Merged
leMaik merged 1 commit intoTeamWertarbyte:masterfrom Apr 15, 2017
rsolomon:prop-types
Merged
Use prop-types lib instead of deprecated React.PropTypes#100leMaik merged 1 commit intoTeamWertarbyte:masterfrom rsolomon:prop-types
prop-types lib instead of deprecated React.PropTypes#100leMaik merged 1 commit intoTeamWertarbyte:masterfrom
rsolomon:prop-types
Conversation
Member
|
Thanks a lot, @rsolomon! Just as a side node: The React devs also recommends to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the prop-types library to avoid React 15.5 deprecation warning.
For testing, ran
npm run buildandnpm run storybookto confirm visual and functional parity.Note that
prop-typeswas added todependencies, as per the recommendations in this PR.