This repository was archived by the owner on Dec 23, 2022. It is now read-only.
Add tips for CJK IME user story#305
Open
vvakame wants to merge 1 commit intoTeamWertarbyte:masterfrom
Open
Conversation
leMaik
reviewed
Jan 22, 2020
| <div> | ||
| add <code>{"newChipKeys={[]}"}</code> to property. | ||
| default is <code>{"newChipKeys={['Enter']}"}</code>. | ||
| prevent onChange event when IME is processing key input. |
Author
There was a problem hiding this comment.
when event.keyCode 13, IME is not processing key input.
when 229, IME is processing key input.
both situations have event.key === 'Enter'. so newChipKeys={[]} is prevent event when IME is processing key input.
My english isn't as good as Japanese, so I'm glad if you can fix it so that it can be understandable. 😺
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #304
add setting example for CJK (Japanese) IME user.
sorry, I can't preview storybook in my local env... 😿