This repository was archived by the owner on Dec 23, 2022. It is now read-only.
Removed negative margin on FormHelperText#310
Open
vdh wants to merge 1 commit intoTeamWertarbyte:masterfrom
Open
Removed negative margin on FormHelperText#310vdh wants to merge 1 commit intoTeamWertarbyte:masterfrom
vdh wants to merge 1 commit intoTeamWertarbyte:masterfrom
Conversation
A negative margin is not how the official TextField handles the FormHelperText, so it shouldn't be baked into this style here. Fixes TeamWertarbyte#266
|
Would be good to get this merged, seeing same issue on my end |
|
This creates another problem. The underlining is moved under the helper text: |
Contributor
Author
|
@dulev I can't debug a screenshot, please provide a reproduction…? |
Contributor
Author
|
From a preliminary investigation (via the Storybook and manually disabling the style in Chrome Developer Tools), it looks like for the The underline for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A negative margin is not how the official TextField handles the FormHelperText, so it shouldn't be baked into this style here.
Fixes #266