build: configure pytest-django and add dev dependencies

apps/web/migrations/0012_vote_web_vote_course__b117a9_idx.py

@@ -0,0 +1,21 @@
+# Generated by Django 5.2.8 on 2026-01-19 02:11
+
+from django.conf import settings
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("web", "0011_remove_course_difficulty_score_and_more"),
+        migrations.swappable_dependency(settings.AUTH_USER_MODEL),
+    ]
+
+    operations = [
+        migrations.AddIndex(
+            model_name="vote",
+            index=models.Index(
+                fields=["course", "category", "value"],
+                name="web_vote_course__b117a9_idx",
+            ),
+        ),
+    ]

apps/web/models/course.py

@@ -41,7 +41,7 @@ def search(self, query):
         elif len(department_or_query) not in self.DEPARTMENT_LENGTHS:
             # must be query, too long to be department. ignore numbers we may
             # have. e.g. "Introduction"
-            return Course.objects.filter(title__icontains=department_or_query)
+            return Course.objects.filter(course_title__icontains=department_or_query)
         # elif number and subnumber:
         #     # course with number and subnumber
         #     # e.g. COSC 089.01
@@ -140,7 +140,7 @@ class Meta:
         ]
 
     def __unicode__(self):
-        return "{}: {}".format(self.short_name(), self.title)
+        return "{}: {}".format(self.short_name(), self.course_title)
 
     def get_absolute_url(self):
         return reverse("course_detail", args=[self.id])

apps/web/tests/conftest.py

@@ -0,0 +1,134 @@
+import pytest
+from django.conf import settings
+from django.urls import reverse
+from rest_framework.test import APIClient
+from apps.web.tests import factories
+
+# -------------------------------------------------------------------------
+# 1. Clients & Authentication
+# -------------------------------------------------------------------------
+
+
+@pytest.fixture
+def base_client():
+    """Returns an unauthenticated API client."""
+    return APIClient()
+
+
+@pytest.fixture
+def user(db):
+    """Returns a saved user instance."""
+    return factories.UserFactory()
+
+
+@pytest.fixture
+def auth_client(user, base_client):
+    """Returns an API client authenticated as the 'user' fixture."""
+    base_client.force_authenticate(user=user)
+    return base_client
+
+
+# -------------------------------------------------------------------------
+# 2. Data Fixtures (Models)
+# -------------------------------------------------------------------------
+
+
+@pytest.fixture
+def course(db):
+    """Returns a saved course instance."""
+    return factories.CourseFactory()
+
+
+@pytest.fixture
+def course_batch(db):
+    """Returns a batch of 3 general courses."""
+    return factories.CourseFactory.create_batch(3)
+
+
+@pytest.fixture
+def department_mixed_courses(db):
+    """Returns a mixed set of courses for filtering/sorting tests."""
+    # Note: Using course_title to match current course model field
+    return [
+        factories.CourseFactory(
+            department="MATH",
+            course_title="Honors Calculus II",
+            course_code="MATH1560J",
+        ),
+        factories.CourseFactory(
+            department="MATH", course_title="Calculus II", course_code="MATH1160J"
+        ),
+        factories.CourseFactory(
+            department="CHEM", course_title="Chemistry", course_code="CHEM2100J"
+        ),
+    ]
+
+
+@pytest.fixture
+def review(db, course, user, min_len):
+    """Returns a saved review instance belonging to 'user'."""
+    return factories.ReviewFactory(course=course, user=user, comments="a" * min_len)
+
+
+@pytest.fixture
+def other_review(db):
+    """Returns a review belonging to a different user for security testing."""
+    from apps.web.tests.factories import UserFactory, ReviewFactory
+
+    return ReviewFactory(user=UserFactory())
+
+
+@pytest.fixture
+def course_factory(db):
+    """Access the factory class directly for custom batch creation."""
+    return factories.CourseFactory
+
+
+# -------------------------------------------------------------------------
+# 3. Validation & Payloads
+# -------------------------------------------------------------------------
+
+
+@pytest.fixture
+def min_len():
+    """Retrieves the minimum comment length from project settings."""
+    return settings.WEB["REVIEW"]["COMMENT_MIN_LENGTH"]
+
+
+@pytest.fixture
+def valid_review_data(min_len):
+    """Generates a valid payload for review creation/update tests."""
+    return {
+        "term": "23F",
+        "professor": "Dr. Testing",
+        "comments": "a" * min_len,
+    }
+
+
+# -------------------------------------------------------------------------
+# 4. URL Fixtures (Routing)
+# -------------------------------------------------------------------------
+
+
+@pytest.fixture
+def course_reviews_url(course):
+    """URL for listing/posting reviews for a specific course."""
+    return reverse("course_review_api", kwargs={"course_id": course.id})
+
+
+@pytest.fixture
+def personal_reviews_list_url():
+    """URL for the current user's personal review list."""
+    return reverse("user_reviews_api")
+
+
+@pytest.fixture
+def personal_review_detail_url(review):
+    """URL for GET/PUT/DELETE a specific review owned by the user."""
+    return reverse("user_review_api", kwargs={"review_id": review.id})
+
+
+@pytest.fixture
+def other_review_detail_url(other_review):
+    """URL for a review NOT owned by the current user (used for 404/Security)."""
+    return reverse("user_review_api", kwargs={"review_id": other_review.id})

apps/web/tests/factories.py

@@ -1,88 +1,79 @@
 import factory
+import factory.fuzzy
 from django.contrib.auth.models import User
 
-from apps.web import models
-from lib import constants
+# Import models from their individual files
+from apps.web.models.course import Course
+from apps.web.models.review import Review
+from apps.web.models.student import Student
+from apps.web.models.course_offering import CourseOffering
 
 
 class UserFactory(factory.django.DjangoModelFactory):
     class Meta:
         model = User
 
-    username = factory.Faker("first_name")
-    email = factory.Faker("email")
-    first_name = factory.Faker("first_name")
-    last_name = factory.Faker("last_name")
-    is_active = True
+    username = factory.Sequence(lambda n: f"user_{n}")
+    email = factory.LazyAttribute(lambda o: f"{o.username}@example.com")
 
     @classmethod
-    def _prepare(cls, create, **kwargs):
-        # thanks: https://gist.github.com/mbrochh/2433411
-        password = factory.Faker("password")
-        if "password" in kwargs:
-            password = kwargs.pop("password")
-        user = super(UserFactory, cls)._prepare(create, **kwargs)
-        user.set_password(password)
-        if create:
-            user.save()
-        return user
+    def _create(cls, model_class, *args, **kwargs):
+        """Ensure password is hashed correctly so auth_client can log in"""
+        password = kwargs.pop("password", "password123")
+        obj = model_class(*args, **kwargs)
+        obj.set_password(password)
+        obj.save()
+        return obj
 
 
 class CourseFactory(factory.django.DjangoModelFactory):
     class Meta:
-        model = models.Course
+        model = Course
 
-    title = factory.Faker("words")
-    department = "COSC"
-    number = factory.Faker("random_number")
-    url = factory.Faker("url")
-    description = factory.Faker("text")
+    course_title = factory.Faker("sentence", nb_words=3)
+    department = factory.fuzzy.FuzzyChoice(["MATH", "PHYS", "EECS"])
+    number = factory.Sequence(lambda n: 100 + n)
+
+    @factory.lazy_attribute
+    def course_code(self):
+        """Generates unique MATH100, PHYS101, etc."""
+        return f"{self.department}{str(self.number):<04}J"
+
+    description = factory.Faker("paragraph")
 
 
 class CourseOfferingFactory(factory.django.DjangoModelFactory):
     class Meta:
-        model = models.CourseOffering
+        model = CourseOffering
 
     course = factory.SubFactory(CourseFactory)
-
-    term = constants.CURRENT_TERM
-    section = factory.Faker("random_number")
+    term = "23F"
+    section = factory.Sequence(lambda n: n)
     period = "2A"
 
 
 class ReviewFactory(factory.django.DjangoModelFactory):
     class Meta:
-        model = models.Review
+        model = Review
 
     course = factory.SubFactory(CourseFactory)
     user = factory.SubFactory(UserFactory)
 
+    term = "23F"
     professor = factory.Faker("name")
-    term = constants.CURRENT_TERM
     comments = factory.Faker("paragraph")
 
 
-class DistributiveRequirementFactory(factory.django.DjangoModelFactory):
-    class Meta:
-        model = models.DistributiveRequirement
-
-    name = "ART"
-    distributive_type = models.DistributiveRequirement.DISTRIBUTIVE
-
-
 class StudentFactory(factory.django.DjangoModelFactory):
     class Meta:
-        model = models.Student
+        model = Student
 
     user = factory.SubFactory(UserFactory)
-    confirmation_link = User.objects.make_random_password(length=16)
 
 
-class VoteFactory(factory.django.DjangoModelFactory):
+class DistributiveRequirementFactory(factory.django.DjangoModelFactory):
     class Meta:
-        model = models.Vote
+        # Using string reference for potential distributive requirements model
+        model = "web.DistributiveRequirement"
 
-    value = 0
-    course = factory.SubFactory(CourseFactory)
-    user = factory.SubFactory(UserFactory)
-    category = models.Vote.CATEGORIES.QUALITY
+    name = factory.Sequence(lambda n: f"Dist{n}")

apps/web/tests/lib_tests/test_terms.py

@@ -34,6 +34,12 @@ def test_term_regex_allows_for_lower_and_upper_terms(self):
             and term_data.group("year") == "16"
             and term_data.group("term") == "w"
         )
+        term_data = terms.term_regex.match("16F")
+        self.assertTrue(
+            term_data
+            and term_data.group("year") == "16"
+            and term_data.group("term") == "F"
+        )
 
     def test_term_regex_allows_for_current_term(self):
         term_data = terms.term_regex.match(constants.CURRENT_TERM)
@@ -52,7 +58,7 @@ def test_numeric_value_of_term_returns_0_if_bad_term(self):
         self.assertEqual(terms.numeric_value_of_term("fall"), 0)
 
     def test_numeric_value_of_term_ranks_terms_in_correct_order(self):
-        correct_order = ["", "09w", "09S", "09X", "12F", "14x", "15W", "16S", "20x"]
+        correct_order = ["", "09w", "09S", "09X", "12F", "14x", "15w", "16S", "20x"]
         shuffled_data = list(correct_order)
         while correct_order == shuffled_data:
             random.shuffle(shuffled_data)
@@ -66,9 +72,10 @@ def test_numeric_value_of_term_gives_expected_numeric_value(self):
         self.assertEqual(terms.numeric_value_of_term("16W"), 161)
 
     def test_is_valid_term_returns_false_if_in_future(self):
-        next_year = (
-            int(terms.term_regex.match(constants.CURRENT_TERM).group("year")) + 1
-        )
+        term_data = terms.term_regex.match(constants.CURRENT_TERM)
+        if term_data is None:
+            raise AssertionError("CURRENT_TERM did not match term_regex")
+        next_year = int(term_data.group("year")) + 1
         self.assertFalse(terms.is_valid_term("{}f".format(next_year)))
 
     def test_is_valid_term_returns_false_if_no_term(self):

apps/web/tests/test_auth.py

@@ -0,0 +1,56 @@
+import pytest
+from django.urls import reverse
+
+from apps.web.tests.factories import ReviewFactory
+
+
+@pytest.mark.django_db
+class TestUserStatusAPI:
+    def test_user_status_anonymous(self, base_client):
+        """Test that unauthenticated users get isAuthenticated=False"""
+        url = reverse("user_status")
+        response = base_client.get(url)
+
+        assert response.status_code == 200
+        assert response.data["isAuthenticated"] is False
+        assert "username" not in response.data
+
+    def test_user_status_authenticated(self, auth_client, user):
+        """Test that authenticated users get isAuthenticated=True and their username"""
+        url = reverse("user_status")
+        # auth_client is already logged in via the fixture in conftest.py
+        response = auth_client.get(url)
+
+        assert response.status_code == 200
+        assert response.data["isAuthenticated"] is True
+        assert response.data["username"] == user.username
+
+
+@pytest.mark.django_db
+class TestLandingPageAPI:
+    def test_landing_page_review_count(self, base_client, review):
+        """Verify landing page shows correct review statistics."""
+        url = reverse("landing_api")
+        response = base_client.get(url)
+        assert response.status_code == 200
+        # Should be at least 1 due to the 'review' fixture
+        assert response.data["review_count"] == 1
+
+    def test_landing_page_review_count_empty(self, base_client, db):
+        """Verify review count is 0 when no reviews exist in the database."""
+        url = reverse("landing_api")
+        response = base_client.get(url)
+
+        assert response.status_code == 200
+        assert response.data["review_count"] == 0
+
+    def test_landing_page_review_count_multiple(self, base_client, db):
+        """Verify review count returns the correct total when multiple reviews exist."""
+        # Create 5 reviews across different courses/users
+        ReviewFactory.create_batch(5)
+
+        url = reverse("landing_api")
+        response = base_client.get(url)
+
+        assert response.status_code == 200
+        assert response.data["review_count"] == 5