Conversation
|
Nice, but:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new interactive course data crawling and import system to replace the old ORC crawling functionality. The new system provides a unified interface for crawling course data from multiple sources (course selection system and official website) with interactive management capabilities.
- Replaces hardcoded ORC crawling with an interactive spider management system
- Implements comprehensive course data integration from multiple APIs
- Adds asynchronous crawling capabilities for improved performance
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/init.py | Replaces old crawling logic with new interactive spider manager |
| pyproject.toml | Adds aiohttp dependency for async HTTP requests |
| apps/spider/manager.py | New comprehensive spider management system with cache and import functionality |
| apps/spider/crawlers/orc.py | Complete rewrite with new CourseSelCrawler class and async capabilities |
| apps/spider/crawlers/README.md | Documentation for the new API endpoints and data structures |
| Makefile | Removes frontend formatting requirement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
apps/spider/manager.py
Outdated
| else: | ||
| # Split by comma (both English and Chinese commas) and clean up | ||
| api_choice = api_choice.replace( | ||
| ",", "," |
There was a problem hiding this comment.
This replacement operation does nothing since both arguments are identical. The comment suggests converting Chinese comma (,) to English comma (,), but both parameters are the same English comma.
| ",", "," | |
| ",", "," |
|
CourseReview/apps/spider/crawlers/medians.py Lines 10 to 11 in 137aac7 old url, plz change |
|
CourseReview/apps/spider/crawlers/orc.py Line 106 in 137aac7 consider using environment variables |
|
CourseReview/apps/spider/crawlers/orc.py Lines 116 to 119 in 137aac7 ... |
|
... |
No description provided.