Open
Conversation
Collaborator
|
私は1 ContributorなのでDeveloper判断に委ねますが、 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker pullのイメージ名が古いままだったのと、Linux上でbuildするとコンテナ内ユーザーのrootでファイルが書き換わってしまい、ホスト側で困ったのでそれを修正する対応を入れています。
本質的にはDockerイメージで実行ユーザーをnon-rootでやるべきなのですが、ちょっと根が深そうなのでshellの中できる範囲で対応を入れました。
macOSでの動作は確認できていない(手元にmacがない)ため、ご確認いただけると幸いです 🙏