Add MIT License, update README, and improve CI workflow#114
Merged
mostafazh merged 7 commits intoJun 17, 2026
Merged
Conversation
README claimed an MIT license but no LICENSE file existed, which defaults the repo to 'all rights reserved' and blocks institutional adoption. Uses TechForPalestine's official MIT license text.
The clone command and project directory referenced the old repo name 'palestine-pfp-maker', which 404s. Update both to 'profile-pic-maker'.
Drop three dependencies with zero imports anywhere in src/: - child_process: an npm squatter, not the Node built-in - sharp: server-only, unreferenced - browser-image-compression: unreferenced Keeps html2canvas, which is earmarked for the pending Linux download fix.
Runs on pull requests and pushes to main. A fresh, version-current workflow rather than the stale community CI PR.
Both effects run once on mount, but their dependency arrays referenced the state they set (unsuportedBrowser, gazaStatusSummary). Use [] to avoid a latent re-run/re-fetch hazard.
Rename the misspelled state variable to unsupportedBrowser (the setter was already correctly spelled).
… link The landing page had two separate footer links: a 'feedback' link pointing to a personal X account (x.com/sohafidz) and a 'report bugs' link pointing to an outdated repo URL. Merge them into one link to the GitHub issues tracker, so feedback, questions, and bug reports all route to a TFP-owned, shared, archived inbox. Closes TechForPalestine#14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new CI workflow, adds a license, and makes several improvements to the codebase and documentation. The most important changes are summarized below.
CI/CD and Licensing:
.github/workflows/ci.ymlto automate linting, type checking, and building the project on pushes and pull requests tomain.LICENSEfile to clarify project usage and distribution rights.Dependency Management:
browser-image-compression,child_process, andsharpfrompackage.jsonto streamline the project. [1] [2]Bug Fixes and Code Quality:
unsuportedBrowserstate variable tounsupportedBrowserthroughoutsrc/app/page.tsx, and corrected the dependency arrays inuseEffecthooks to prevent unnecessary re-renders. [1] [2] [3]Documentation Updates:
README.mdto reflect the correct GitHub repository URL and directory name.