test(e2e): disambiguate New now that the tree can make a page too - #17
Merged
Conversation
The release check failed on `getByRole("button", { name: "New" })`: Playwright matches
accessible names by substring, and the sidebar's "New page" is now a second match. Made
exact.
Caught by the release job rather than by `pnpm e2e`, which does not run first-run — it
drives a built bundle against an empty vault, and that is the only place the two buttons
appear on screen together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release job's first-run check failed on
getByRole("button", { name: "New" }). Playwright matches accessible names by substring, and the sidebar's "New page" is a second match, so the locator was ambiguous.Made exact. Verified against a freshly built bundle and an empty vault, which is the only place both buttons are on screen at once — and the reason
pnpm e2edid not catch it.🤖 Generated with Claude Code