Implement VarintRead and VarintWrite for all readers and writers (resp.)#5
Open
nham wants to merge 2 commits intoTechern-archived:masterfrom
Open
Implement VarintRead and VarintWrite for all readers and writers (resp.)#5nham wants to merge 2 commits intoTechern-archived:masterfrom
nham wants to merge 2 commits intoTechern-archived:masterfrom
Conversation
Member
|
Thank you for this :) I'm not at my usual computer at the moment but I'll review it properly and make any changes (if required) through the week |
Author
|
Thinking about this again, is there any impediment to just doing: impl<T> VarintRead for T where T: Read { }
impl<T> VarintWrite for T where T: Write { }I've updated it to this in the PR, and it seems to be working fine. |
nham
changed the title
Member
|
Sorry about this taking so long; I've just updated this in IoOperations so I'll merge this in while #4 is being worked on |
|
What happened to this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.