Solves #22#27
Open
spacemonkey1101 wants to merge 7 commits intoTechnical-Hackers:masterfrom
spacemonkey1101:master
Open
Solves #22#27spacemonkey1101 wants to merge 7 commits intoTechnical-Hackers:masterfrom spacemonkey1101:master
spacemonkey1101 wants to merge 7 commits intoTechnical-Hackers:masterfrom
spacemonkey1101:master
Conversation
iamsh4shank
requested changes
Dec 16, 2020
Contributor
iamsh4shank
left a comment
There was a problem hiding this comment.
Hey, @spacemonkey1101 nice work, check my comments also please squash the commits
Contributor
|
squash the commits |
Contributor
|
Hey @spacemonkey1101 please add a screen shot and also squash your commits :) |
Author
Contributor
|
Yeah, you need to manage each color for dark mode and light mode, for now, you can just add a basic color and then send a PR and then, later on, send another PR for adding the new colors for dark and light mode. Also, I would suggest you add this switch thing or maybe a theme button on the top overflow menu(inside three dots). After a few days, we are going to add a Setting page then we will shift all these things there :) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Solves #22
Sorry for making 2 commits. I actually forgot to fetch upstream.
Please tell me if the changes are ok