Skip to content

Todo App- Agnes Sjösten#38

Open
AgnesSj01 wants to merge 2 commits intoTechnigo:mainfrom
AgnesSj01:main
Open

Todo App- Agnes Sjösten#38
AgnesSj01 wants to merge 2 commits intoTechnigo:mainfrom
AgnesSj01:main

Conversation

@AgnesSj01
Copy link
Copy Markdown

Created components for the todo list, todo form, and todo counter, as well as style files for the app. Also moved some code into utils files to improve code readability.

…well as style files for the app. Also moved some code into utils files to improve code readability
@AgnesSj01 AgnesSj01 changed the title Created the app Todo App- Agnes Sjösten Jan 13, 2026
Copy link
Copy Markdown

@Npahlfer Npahlfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how you've organized the code into separate files for the store, the utils, and the styles, it makes the app much easier to read and maintain. You have also separated the UI components which is a good practice. I see that you implemented local storage to save the tasks, so they persist when you refresh the page, nice!

I did spot a small spelling mistake in the TodoForm component. You named the function handleSumbit, but it should be handleSubmit. Not a biggie, but nice for correctness :)

In the TodoList component, you have a checkbox inside the TodoButton. While it works, it is a bit unusual to have an input inside a button element like that. You could try to handle the click on the TodoButton instead, or move the checkbox out of the button tag to make the code a bit cleaner. It's also nice to see that you included an empty state message when there are no tasks, good UX!

I did noticed you added Tailwind CSS to your package.json, but I don't see it being used in your code files. If you aren't using it, you can remove it from the dependencies to keep things clean.
Also I'm missing a link to the deployed app :)

Overall good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants