Skip to content

TodoList by Asako and Julia#39

Open
julialindstrand wants to merge 12 commits intoTechnigo:mainfrom
julialindstrand:main
Open

TodoList by Asako and Julia#39
julialindstrand wants to merge 12 commits intoTechnigo:mainfrom
julialindstrand:main

Conversation

@julialindstrand
Copy link
Copy Markdown

Copy link
Copy Markdown

@Npahlfer Npahlfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you have organized the app. It looks clean and the use of the Header and Footer components gives the app a nice structure. The logic for adding and removing tasks works well. And I like the empty state you implemented with the Lottie animation, it looks nice and completes the UX nicely.

Make sure to add an alt attribute to the logo in the Header component. Since it is an image, it is important for accessibility so people using screen readers know what the image is.

Also, in the ToDoInput component, you call event.preventDefault() inside your add function. Make sure to keep that inside a <form> tag, otherwise it might not be doing what you expect. It's good practice to wrap your input and button in a form if you are submitting data.

It is nice to see you guys are using the theme file for colors and styles.

Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants