Skip to content

Todo project Frida#41

Open
fridascript wants to merge 6 commits intoTechnigo:mainfrom
fridascript:main
Open

Todo project Frida#41
fridascript wants to merge 6 commits intoTechnigo:mainfrom
fridascript:main

Conversation

@fridascript
Copy link
Copy Markdown

Please include your Netlify link here: [https://todo-project-frida.netlify.app/]

Copy link
Copy Markdown

@Npahlfer Npahlfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the storage implementation with zustands persist middleware to save tasks to local storage. The empty state in the todo list (No tasks yet ✨) is a nice touch, and I like how the app layout shifts to a two-column view on larger screens. But maybe it would nice to put the input box outside of the Todo box?

Also, the remove button uses an emoji (🗑️) which might not be accessible for screen readers. Adding an aria-label="Remove task" would make it better for all users.

One small suggestion: you're using #9B9DFF in multiple places for checkboxes and text (like in TodoItem.jsx and DoneTasks.jsx). It would make your code easier to update later if you put that color in a theme file (like theme.js).

Overall, great job! You've covered all the core requirements and nailed the local storage stretch goal. Good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants