Skip to content

Todo-app#43

Open
sandrahagevall wants to merge 15 commits intoTechnigo:mainfrom
sandrahagevall:main
Open

Todo-app#43
sandrahagevall wants to merge 15 commits intoTechnigo:mainfrom
sandrahagevall:main

Conversation

@sandrahagevall
Copy link
Copy Markdown

Copy link
Copy Markdown

@Npahlfer Npahlfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the todo app! The dark‑mode toggle with the icon and smooth transition to a dark background is a nice touch for accessibility and personalization. . I like the empty‑state UX: a friendly message with the skeleton placeholder keeps the app from feeling blank.

The form is a strong stretch goal win, adding text, a category select, and a date picker is handy for real‑world use, and storing the date as an ISO string while formatting it with date‑fns keeps data handling clean. Showing the created date, due date, and an overdue badge in each item is great for quick status checks. The use of framer‑motion for entry animation gives the list a polished feel.

Also good that you are persisting the store with zustand and the completeAllTodos button in the heading is a nice touch.

A small cleanup note: the completeTodo action in the store isn’t used anywhere (you toggle completion via toggleTodo), so it could be removed to keep the codebase lean and tidy. Likewise, the categories array is defined but not currently used. If you plan to use it elsewhere, thats fine, otherwise you could drop it.

Overall, the app hits every requirement with a few great stretch goals. The code is readable, the UI is responsive and accessible, and the developer experience is solid. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants