Skip to content

Todo - Assignment #45

Open
qabalany wants to merge 7 commits intoTechnigo:mainfrom
qabalany:main
Open

Todo - Assignment #45
qabalany wants to merge 7 commits intoTechnigo:mainfrom
qabalany:main

Conversation

@qabalany
Copy link
Copy Markdown

Copy link
Copy Markdown

@Npahlfer Npahlfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of styled components (and its props), structured, easy to read. You have done a really great job with this app. Not much to comment on, besides maybe having one place for colors, media queries and maybe even to start thinking about unified sizing? Like having a spacing unit that you can reuse throughout your app.

It would also be nice to have one place for icons, at the moment that are a bit scattered throughout the components. Try to make them into their own components and have a wrapper <Svg> component that takes care of the <svg> common attributes.

Otherwise really well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants