Skip to content

To-Do project, Julia D.#54

Open
Demijuls wants to merge 14 commits intoTechnigo:mainfrom
Demijuls:main
Open

To-Do project, Julia D.#54
Demijuls wants to merge 14 commits intoTechnigo:mainfrom
Demijuls:main

Conversation

@Demijuls
Copy link
Copy Markdown

Copy link
Copy Markdown

@Npahlfer Npahlfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your todo app Iuliia!
The empty state animation with Lottie looks good and gives the page a nice feel. You have not only the core requirements and but also implemented three stretch goals, a timestamp on each task (so users can see when a task was added), a priority selector and a “Complete all” button in the heading. Nice!

The TodaysDate component updates every minute without a page refresh, which is a thoughtful UX touch.

Good that you have used css variables to make maintenance easier, there are though a few places with hardcoded colors. It would be nice to change those into variables as well along with the media queries. Or having it in a theme file would work too!

Overall you’ve met every core requirement, implemented three stretch goals, and delivered a responsive, accessible, and nice looking app. Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants