Skip to content

Update todo app with design system and component structure#55

Open
akiwumi wants to merge 1 commit intoTechnigo:mainfrom
akiwumi:main
Open

Update todo app with design system and component structure#55
akiwumi wants to merge 1 commit intoTechnigo:mainfrom
akiwumi:main

Conversation

@akiwumi
Copy link
Copy Markdown

@akiwumi akiwumi commented Jan 19, 2026

Copy link
Copy Markdown

@Npahlfer Npahlfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on you todo app Pebbles, it looks consistent and clean.
And you have set up the design system completely with all the tokens, colors, and responsive breakpoints, but none of the stretch goals have been implemented yet. Adding a timestamp for each task (using a library like date‑fns) or a “complete all” button would be great next steps. Also, a dark/light mode switch and local storage would help push this towards VG.

One small thing, the app currently doesn’t show a count of your tasks (either total or incomplete), which is a core requirement. Adding a line above with the todos count would satisfy that :)

When using index files like you have done in eg. todoitem try have another file in there that is named the same thing as the folder/component name and then export that file from the index file. Because when searching for files it's annoying to just see a bunch of index files, at this scale it doesnt matter, but with bigger projects it will show.

There is also some inline styling, try to keep inline styling to a minimum and only use it for dynamic styling that changes a lot, because inline styling doesnt follow the normal cascading rule.

Overall good job with this and make sure to add the todo count! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants