Skip to content

Leon hand in#56

Open
LeonEkelund wants to merge 3 commits intoTechnigo:mainfrom
LeonEkelund:main
Open

Leon hand in#56
LeonEkelund wants to merge 3 commits intoTechnigo:mainfrom
LeonEkelund:main

Conversation

@LeonEkelund
Copy link
Copy Markdown

Copy link
Copy Markdown

@Npahlfer Npahlfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with you still(goyo) todo app!
All the essential features are solid, and the code is cleanly split into small, focused components. For stretch goals, you are already storing an id and text, so appending a raw timestamp or a “complete all” button would be a smooth next step. Localstorage persistence would also round up the score and overall UX.

At the moment you have a svg icon directly in the AddTodo component, it would be nicer to have icons in their own named files.

But overall well done with the state management and the overall app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants