Labyrinth project by Emilia, Nina & Sandra week 12#196
Labyrinth project by Emilia, Nina & Sandra week 12#196SandraMadeleine wants to merge 13 commits intoTechnigo:masterfrom
Conversation
EmmaHoltegaard
left a comment
EmmaHoltegaard
left a comment
There was a problem hiding this comment.
Good job guys! Everything works as it should and all the requirements are met. A+.
| ) | ||
| } | ||
| return ( | ||
| <Outerwrapper coordinates={coordinates}> |
There was a problem hiding this comment.
Cool that you've used the coordinated to create this logic.
|
|
||
| return ( | ||
| <Direction> | ||
| <DirectionBtn1 className={isActive ? 'hidden-btn' : null} type="button" onClick={toggleDisplay}>Directions</DirectionBtn1> |
There was a problem hiding this comment.
Nice touch with the toggleDisplay. It adds something to the UX that you have to click to see the directions.
| reducers: { | ||
|
|
||
| setUsername: (state, action) => { | ||
| state.username = `${new Date().getTime()}+${action.payload}` |
There was a problem hiding this comment.
Makes a big difference that you added the time-stamp.
| return ( | ||
| <Outerwrapper coordinates={coordinates}> | ||
| <Innerwrapper> | ||
| {coordinates === '' && <StartScreen />} |
There was a problem hiding this comment.
These two lines could probably be shortened to {coordinates === '' ? : }, or something like that, I think :)
|
|
||
| return ( | ||
| <Direction> | ||
| <DirectionBtn1 className={isActive ? 'hidden-btn' : null} type="button" onClick={toggleDisplay}>Directions</DirectionBtn1> |
There was a problem hiding this comment.
Kind of the reverse of my last comment :), I remember reading that you could use className={isActive && 'hidden-btn'} instead of using null!
4 participants
https://labyrinthw12-reactredux.netlify.app/