Open
Conversation
HIPPIEKICK
approved these changes
Sep 13, 2024
Contributor
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Great job on your project! 🎉
JavaScript
- The if-else structure for checking valid food choices (foodNumber >= 1 && foodNumber <= 3) is implemented correctly. Nice work! For readability, you could consider combining this logic with your switch case that follows right after.
- Nice that you tried both if/else and switch ⭐
- Using template literals (backticks) to embed variables inside strings makes your code cleaner and more readable. Keep this up 👍
- The use of the function ageString is a good step toward writing modular code. One suggestion: instead of calling it ageString, you could name the function after what it does, such as decideDishSize or checkAge
Clean Code
- The indentation is consistent, which helps in readability. Keeping it uniform is key, and you’ve done well here.
- Overall very descriptive variable names ⭐
Well done Mika, keep up the good work 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://mikaspizzeria.netlify.app/