Skip to content

Portfolio Nellax#385

Open
nella-x wants to merge 20 commits intoTechnigo:mainfrom
nella-x:main
Open

Portfolio Nellax#385
nella-x wants to merge 20 commits intoTechnigo:mainfrom
nella-x:main

Conversation

@nella-x
Copy link
Copy Markdown

@nella-x nella-x commented Nov 3, 2024

Netlify link

Add your Netlify link here.
PS. Don't forget to add it in your readme as well.

https://nellax.netlify.app/

@JennieDalgren JennieDalgren self-assigned this Nov 7, 2024
JennieDalgren
JennieDalgren previously approved these changes Nov 7, 2024
Copy link
Copy Markdown
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with the portfolio,

Your version differs a bit from the given design, spacing, padding, sizes and fonts are not as they should. Take a look at the Figma file and follow the design thoroughly.

Keep it up!

Copy link
Copy Markdown
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with the portfolio,

Your version differs a bit from the given design, spacing, padding, sizes and fonts are not as they should. Take a look at the Figma file and follow the design thoroughly.

Keep it up!

@nella-x
Copy link
Copy Markdown
Author

nella-x commented Dec 30, 2024

Hello! I've done som updates to the css now! I think that now it's only the images that are a different size from the design, but I prefer the square style. And the buttons are on top of eachother insted of side by side. If you want me to change this also, just let me now.

@HIPPIEKICK
Copy link
Copy Markdown
Contributor

Some things I noticed:

  • Some font-weigths are still a bit too heavy
  • The tech section is too wide on tablet
  • Skills section should be centered on tablet
  • Top/bottom-padding for each section too small

With this said, overall it looks really good but have another look at the design to really nail those nitty-gritty details to make your project pop design-wise 🔍 🪄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants