Skip to content

project-12-portfolio#396

Draft
erikamolsson wants to merge 28 commits intoTechnigo:mainfrom
erikamolsson:main
Draft

project-12-portfolio#396
erikamolsson wants to merge 28 commits intoTechnigo:mainfrom
erikamolsson:main

Conversation

@erikamolsson
Copy link
Copy Markdown

@erikamolsson erikamolsson commented Nov 4, 2024

@JennieDalgren JennieDalgren self-assigned this Nov 7, 2024
Copy link
Copy Markdown
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netlify link not working and it looks like you pushed all node modules to github? you have more than 5000 files :D

@erikamolsson erikamolsson marked this pull request as draft January 5, 2025 11:41
@erikamolsson
Copy link
Copy Markdown
Author

Hopefully i managed to remove all node-files from the repository and updated the Netlify link. I didn't now what to put on the "article" section so I have the project there as well for now.

Copy link
Copy Markdown
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested
Have another look at your page in mobile (320px width):

  • Your content doesn't fit
  • Your profile image is oval
  • The skills list's text is too small

In general, I'd like to ask you to go through all different widths to check how your page looks. Apart from this, double check spaces (margin, padding, gaps etc) and sizes (on fonts, images) and fonts (e.g. the buttons have Arial).

You've done a massive work fixing up old projects, so keep up the good work 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants