Conversation
Maryyy-ux
left a comment
Maryyy-ux
left a comment
There was a problem hiding this comment.
Hi Jonas, awesome portfolio project, just left two constructive comments.
src/components/project/Project.css
Outdated
| align-items: center; | ||
| } | ||
|
|
||
| @media (min-width: 768px) { |
There was a problem hiding this comment.
Smart media queries! Love that! Everything under control and defined. Congrats!
| @@ -0,0 +1,36 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
| import React from "react"; | |
| import React from "react"; |
Oops, maybe this is a missing pillow. Seems its not required.
JennieDalgren
left a comment
JennieDalgren
left a comment
There was a problem hiding this comment.
Great job with the projects.
Almost got everything right. Make sure to go through the design again and check all sizes, paddings, widths and spacings.
This is an example on where your code differs too much from the design provided.
Keep up the good work! :
|
@JennieDalgren I have updated the design to better align with the provided mockup. Changes have been made for mobile, tablet, and desktop views. :) |
Maryyy-ux
left a comment
Maryyy-ux
left a comment
There was a problem hiding this comment.
Perfectly done! Congrats Jonash189
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Please go through all spacings another time, here's an example of a thing that is not according to design, it should be 128px top and 64px bottom. Apart from that - check the dark/light mode rules (might be Vite's default) because it looks broken in some places with dark mode on.
|
|
||
| color-scheme: light dark; | ||
| color: white; | ||
| background-color: #242424; |
4 participants
URL: https://jonashellstrom-portfolio.netlify.app/