Skip to content

Week 12: Portfolio#399

Open
jacquelinekellyhunt wants to merge 16 commits intoTechnigo:mainfrom
jacquelinekellyhunt:main
Open

Week 12: Portfolio#399
jacquelinekellyhunt wants to merge 16 commits intoTechnigo:mainfrom
jacquelinekellyhunt:main

Conversation

@jacquelinekellyhunt
Copy link
Copy Markdown

@jacquelinekellyhunt jacquelinekellyhunt commented Nov 4, 2024

@JennieDalgren JennieDalgren self-assigned this Nov 7, 2024
Copy link
Copy Markdown
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with this project.
You're are almost there. Got through the design and really compare sizes and spacings and fonts thoroughly. Also it looks like you forgot the gitignore file, since your node modules got pushed to github. it means your project includes more than 5000 files.

image Here is an example on where your project differs too much from the design.

@jacquelinekellyhunt
Copy link
Copy Markdown
Author

@JennieDalgren thank you for pointing that out - I made some changes, and I hope this aligns with the requirements. Please let me know when anything else is necessary to change <3

Copy link
Copy Markdown
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kelly! Here's an example of where your spacings don't adhere to the design. Also, please remove the node modules as Jennie mentioned.
Skärmavbild 2024-12-09 kl  11 24 05

Go through the design screen by screen and compare it to the design., and make sure you're importing the font correctly - it seems to be broken.

@HIPPIEKICK
Copy link
Copy Markdown
Contributor

Still the wrong font and some spacing inadequacy

@jacquelinekellyhunt
Copy link
Copy Markdown
Author

@HIPPIEKICK I sincerely hope the changes are ok 😅

Copy link
Copy Markdown
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants