Open
Conversation
HIPPIEKICK
requested changes
Dec 9, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Remove your node modules so that we can do a proper review of your code, as well as remove any dark/light mode styling you have as I think that's what's causing your portfolio to look broken. After that I can do a more thorough review.
HIPPIEKICK
previously requested changes
Mar 5, 2025
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
You're off to a good start Helene, but you still need to work on the design a bit. Make sure it looks good on all screen widths (and get rid of the side scroll) and take another look at the design. Be as thorough as you can and go through spacings and such.
Contributor
|
Code wise you are approved! - just remember to change the content to be yours. It says Sara in some places and the photo in the end of the site is the placeholder image. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://helenes-portfolio.netlify.app/