Skip to content

renew#406

Open
smily342 wants to merge 9 commits intoTechnigo:mainfrom
smily342:main
Open

renew#406
smily342 wants to merge 9 commits intoTechnigo:mainfrom
smily342:main

Conversation

@smily342
Copy link
Copy Markdown

Netlify link

Add your Netlify link here.
PS. Don't forget to add it in your readme as well.

Copy link
Copy Markdown
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the design files closely and make sure your coded version matches the figma version.

@smily342
Copy link
Copy Markdown
Author

waiting for viewing

Copy link
Copy Markdown
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late feedback Brian, but amazing progress here ⭐ Just a couple of things left:

  • Make sure it's responsive so that there's no side scroll in mobile for example
  • Make sure all contrasts are OK. You can use Lighthouse to test this. Tip: test in both dark mode and light mode or at least make sure your portfolio looks the same in dark mode as in light mode.

Almost there 💪 Request a re-review here on GitHub when you're ready.

@smily342
Copy link
Copy Markdown
Author

Contrast ratio issues in dark mode
Accessibility labels for icon links
went from 84% to 95% accessibiliy on lighthouse @JennieDalgren @HIPPIEKICK

@smily342
Copy link
Copy Markdown
Author

smily342 commented May 20, 2025 via email

@HIPPIEKICK
Copy link
Copy Markdown
Contributor

See this screenshot of how it looks for me (I have dark mode turned on, that's why I asked you to try it in dark mode as well). If you don't want a specific dark mode styling you can remove that part from your CSS.
Screenshot 2025-05-22 at 11 53 31

Responsiveness looks better! Just make sure that your projects get the same padding as your articles, see images below:

Screenshot 2025-05-22 at 11 56 39 Screenshot 2025-05-22 at 11 57 26

@smily342
Copy link
Copy Markdown
Author

fixing light and dark mode issues
padding and accessibility

@smily342
Copy link
Copy Markdown
Author

To resolve contrast and accessibility issues for both light and dark modes, I had to slightly alter the original design.
accessibility is 100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants