Open
Conversation
JennieDalgren
previously requested changes
Apr 8, 2025
Contributor
JennieDalgren
left a comment
There was a problem hiding this comment.
Take a look at the design files closely and make sure your coded version matches the figma version.
Author
|
waiting for viewing |
HIPPIEKICK
requested changes
May 13, 2025
Contributor
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Sorry for the late feedback Brian, but amazing progress here ⭐ Just a couple of things left:
- Make sure it's responsive so that there's no side scroll in mobile for example
- Make sure all contrasts are OK. You can use Lighthouse to test this. Tip: test in both dark mode and light mode or at least make sure your portfolio looks the same in dark mode as in light mode.
Almost there 💪 Request a re-review here on GitHub when you're ready.
Author
|
Contrast ratio issues in dark mode |
Author
|
Hey there Mathilda thank you for coming back to me
We the last change I did this weekend.
Im ready for a new a review
Take care
Le 2025-05-13T13:23:13.000+02:00, Matilda Brunemalm
***@***.***> a écrit :
***@***.*** requested changes on this pull request.
Sorry for the late feedback Brian, but amazing progress here ⭐
Just a couple of things left:
* Make sure it's responsive so that there's no side scroll in
mobile for example
* Make sure all contrasts are OK. You can use Lighthouse to test
this. Tip: test in both dark mode and light mode or at least make
sure your portfolio looks the same in dark mode as in light mode.
Almost there 💪 Request a re-review here on GitHub when you're
ready.
—
Reply to this email directly, view it on GitHub
[#406 (review)],
or unsubscribe
[https://github.com/notifications/unsubscribe-auth/BKPH7WPLGEUZGBNWXAZTUXL26HIZ7AVCNFSM6AAAAABXX55U62VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQMZWGMZTOMRSGI].
You are receiving this because you authored the thread.Message ID:
***@***.***>
Envoyé avec la messagerie d'Infomaniak [https://ik.me], The Ethical
Cloud.
|
Contributor
Author
|
fixing light and dark mode issues |
Author
|
To resolve contrast and accessibility issues for both light and dark modes, I had to slightly alter the original design. |
HIPPIEKICK
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Netlify link
Add your Netlify link here.
PS. Don't forget to add it in your readme as well.